it seems that not all of our dependencies are ready for 8.5 support:

• [halaxa/json-machine](Add support for PHP 8.5 halaxa/json-machine#127)
• openspout/openspout - requires higher version
• cocur/slugify replaced with symfony/string by @stloyd
• nixpkgs 8.5

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.54%. Comparing base (91acbdf) to head (ed0c8df).
⚠️ Report is 3 commits behind head on 1.x.
✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##              1.x    #1906   +/-   ##
=======================================
  Coverage   79.54%   79.54%           
=======================================
  Files         831      831           
  Lines       24690    24690           
=======================================
  Hits        19640    19640           
  Misses       5050     5050           

Once halaxa/json-machine#127 is merged we can move forward with this one!

https://github.com/halaxa/json-machine/blob/1.2.6/CHANGELOG.md

Has been released with 8.5 support.

Could you merge this please and publish a new release? This dependency is blocking me from upgrading my stack to 8.5.

Hey @Buffele I'm thinking about brining basic support for 8.5 (meaning that composer wont block it) in next few days.
But Full migration, I'm afraid this will take a bit longer, I need also to upgrade whole codebase to 8.3, go through all github workflows (make sure they also work on 8.3 only)

So in other words those are still blockers:

• upgrade codebase to 8.3
• drop support for 8.2
• compile WASM on 8.5
• update Dockerfile and (need to move installation to pie)
• update our nix shell

@drupol how far is your PR bringing 8.5 from being merged to nixpgs?

@drupol how far is your PR bringing 8.5 from being merged to nixpgs?

The PR is made since quite a while now... waiting for people to review it. Feel free to test it and provide some feedback.

@drupol how far is your PR bringing 8.5 from being merged to nixpgs?

The PR is made since quite a while now... waiting for people to review it. Feel free to test it and provide some feedback.

I'm more than happy to help in any way that is needed to get this one merged!

To test this PR I just need to point my nix shell towards your fork and commit that brings 8.5?

To test this PR I just need to point my nix shell towards your fork and commit that brings 8.5?

There are many ways to do that and this is a valid way to achieve this indeed.

Hey @Buffele I'm thinking about brining basic support for 8.5 (meaning that composer wont block it) in next few days.

Thanks for your quick reply.

Basic support is completely fine with me. As long as I can run composer install and bump the minimum php version without worries.

Thanks!